ocis driver: synctime based etag propagation #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
force-pushed
the
ocis-synctime-accounting
branch
2 times, most recently
from
adf4357 to
eb4acee
Compare
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
ocis-synctime-accounting
branch
from
eb4acee to
998e6fa
Compare
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
ocis-synctime-accounting
branch
from
998e6fa to
bbe22ea
Compare
butonic
changed the title
labkode
approved these changes
Sep 21, 2020
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr changes the etag from a dedicated property to a calculated property, based on fileid and mtime.
It also introduces a treetime (tmtime), similar to eos synctime, which is used to indicate when the subtree last changed.
The traatime accounting is enabled for nodes which have the
user.ocis.propagationextended attribute set to1. We could change this to a more readable format, egnone,syncorasync. Then we could make the propagation strategy configurable. Currently, propagation is in sync, which does require a lot of updates.I also turned all magic strings for extended attributes into constants.
the logic is the same as in eos: the parent nodes tmtime is checked and updated if it is older than the mtime of the changed node, up to the root.